Skip to content

chore: add prefix on get record and index#134

Merged
MicBun merged 4 commits intomainfrom
chore/prefix-on-record-index
Jun 20, 2025
Merged

chore: add prefix on get record and index#134
MicBun merged 4 commits intomainfrom
chore/prefix-on-record-index

Conversation

@williamrusdyputra
Copy link
Copy Markdown
Contributor

@williamrusdyputra williamrusdyputra commented Jun 20, 2025

Related Problem

resolves: trufnetwork/node#1013

How Has This Been Tested?

Screenshot 2025-06-20 at 12 40 36

@williamrusdyputra williamrusdyputra self-assigned this Jun 20, 2025
@williamrusdyputra
Copy link
Copy Markdown
Contributor Author

@MicBun do you think for this change, we should add test or example or both?

@MicBun
Copy link
Copy Markdown
Collaborator

MicBun commented Jun 20, 2025

Yes, you got the point. I do think an example is needed @williamrusdyputra

@williamrusdyputra
Copy link
Copy Markdown
Contributor Author

@MicBun because the package which have a prefix isn't available yet, should I change the version to 0.3.2 on all examples, then update the package after this PR merged?

not sure about the steps

@williamrusdyputra
Copy link
Copy Markdown
Contributor Author

log: using main in go.mod, then when user run go mod tidy, it will resolves to latest version / commit from main branch on our repo. Added the command to readmes.

@williamrusdyputra williamrusdyputra requested a review from MicBun June 20, 2025 09:14
@williamrusdyputra williamrusdyputra marked this pull request as ready for review June 20, 2025 09:14
@holdex
Copy link
Copy Markdown

holdex bot commented Jun 20, 2025

Time Submission Status

Member Status Time Action Last Update
williamrusdyputra ✅ Submitted 2h Update time Jun 20, 2025, 9:30 AM
MicBun ✅ Submitted 20min Update time Jun 20, 2025, 9:32 AM

@MicBun MicBun merged commit 0155e2d into main Jun 20, 2025
2 checks passed
@MicBun MicBun deleted the chore/prefix-on-record-index branch June 20, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem: SDKs are not updated to use actions with prefix

2 participants