fix: remove unused GetIndexChangeWithMetadata

[outerlook]

Description

• remove unused funciton

Related Problem

• fix Bug: StreamIndexChangeWithMetadata not defined #145

How Has This Been Tested?

Summary by CodeRabbit

• Refactor
  • Removed a method related to retrieving index changes with metadata. No changes to user-facing features or functionality.
• Style
  • Minor whitespace cleanup for improved code readability (no impact on user experience).

[coderabbitai]

"""

Walkthrough

The GetIndexChangeWithMetadata function was fully removed from the codebase. This function previously handled the retrieval and processing of index change data with metadata. No other significant changes were made, aside from a minor whitespace adjustment in another method.

Changes

File(s)	Change Summary
core/contractsapi/stream_procedures.go	Removed the GetIndexChangeWithMetadata function; minor whitespace cleanup in GetFirstRecord.
tests/integration/cache_functionality_test.go	Updated test to call GetIndexChange instead of removed GetIndexChangeWithMetadata; adjusted assertions to check Results field and validate metadata accordingly.

Sequence Diagram(s)

Not applicable: The change is a function removal without new or altered control flow.

Possibly related PRs

• chore: enable get index change cache metadata support #143: Added the GetIndexChangeWithMetadata method, which is now being removed by this PR.

Poem

A function once fetched change and lore,
But now it resides in code no more.
With whitespace neat and methods trimmed,
The codebase hops on, unencumbered, undimmed.
🐇✨
"""

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[outerlook]

future might be good to add our CI here too

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

tests/integration/cache_functionality_test.go (1)

282-282: Update test name to reflect the actual method being called.

The method call change from GetIndexChangeWithMetadata to GetIndexChange is correct and aligns with the removal of the specialized method. However, the test name "GetIndexChangeWithMetadata" no longer matches the method being called.

Consider updating the test name to reflect that it's testing GetIndexChange with metadata validation:

-	t.Run("GetIndexChangeWithMetadata", func(t *testing.T) {
+	t.Run("GetIndexChange with metadata validation", func(t *testing.T) {

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eba388c and 4be31e7.

📒 Files selected for processing (1)

• tests/integration/cache_functionality_test.go (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

tests/integration/cache_functionality_test.go (1)

core/types/stream.go (1)

• GetIndexChangeInput (25-35)

🔇 Additional comments (2)

tests/integration/cache_functionality_test.go (2)

299-299: LGTM: Assertion correctly updated for unified API.

The assertion has been properly updated to check result.Results instead of the removed IndexChanges field, maintaining the same validation logic with the consolidated API response structure.

---

302-302: LGTM: Length assertion correctly updated for unified API.

The length assertion has been properly updated to check len(result.Results) instead of the removed IndexChanges field, maintaining the same validation logic with the consolidated API response structure.

[holdex]

Time Submission Status

Member	Status	Time	Action	Last Update
@outerlook	❌ Missing	-	⚠️ Submit time	-
MicBun	✅ Submitted	15min	Update time	Jul 18, 2025, 9:35 AM

[holdex]

Bug Report Checklist

Status	Commit Link	Bug Author
❌ Not Submitted	–	–

@outerlook, please use git blame and specify the link to the commit link that has introduced this bug.

Send the following message in this PR: `@pr-time-tracker bug commit [link](url) && bug author @name`

[MicBun]

nice catch