Conversation
WalkthroughAdds a recipient parameter to withdrawal flow: client withdraw now takes (chain, amount, recipient) and passes it to Action.bridgeTokens, which also updates its signature and payload to include recipient. Existing wait and tx_hash handling remain unchanged. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Client
participant Action
participant BridgeRPC as Bridge RPC
User->>Client: withdraw(chain, amount, recipient)
Client->>Action: bridgeTokens(chain, amount, recipient)
Action->>BridgeRPC: bridge_tokens { chain, $amount, $recipient }
BridgeRPC-->>Action: tx_hash or error
alt tx_hash present
Action-->>Client: tx_hash
Client->>BridgeRPC: waitForTx(tx_hash)
BridgeRPC-->>Client: confirmation
Client-->>User: tx_hash
else missing tx_hash
Action-->>Client: error
Client-->>User: error
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
Time Submission Status
|
|
@MicBun sepolia bridge is not enabled yet on mainnet hence the ERC20 bridge test failed. |
|
@williamrusdyputra alright, make sure it is backlogged, so we don't forget to fix the test later on |
resolves: https://github.com/trufnetwork/truf-network/issues/1201
Summary by CodeRabbit