Skip to content

fix: view list_attestations on example#138

Merged
MicBun merged 1 commit intomainfrom
fixbytea
Nov 7, 2025
Merged

fix: view list_attestations on example#138
MicBun merged 1 commit intomainfrom
fixbytea

Conversation

@MicBun
Copy link
Copy Markdown
Member

@MicBun MicBun commented Nov 7, 2025

resolves: https://github.com/trufnetwork/truf-network/issues/1336

Summary by CodeRabbit

  • Bug Fixes
    • Improved parameter handling in the attestation list request functionality for enhanced data compatibility and reliability.

@MicBun MicBun requested a review from outerlook November 7, 2025 11:29
@MicBun MicBun self-assigned this Nov 7, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 7, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The listAttestations function in the attestation action contract API was modified to change parameter handling. The $requester parameter now accepts a raw Uint8Array directly when provided, rather than being base64-encoded before submission. No changes to control flow, error handling, or result processing.

Changes

Cohort / File(s) Summary
Parameter Encoding Adjustment
src/contracts-api/attestationAction.ts
Modified $requester parameter to pass raw Uint8Array directly instead of base64-encoding the string when provided; empty bytes remain default when absent

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Single file modification affecting one parameter in a focused function
  • Straightforward logic change with no complex conditional flows
  • Verify that the raw Uint8Array format is compatible with downstream contract expectations and that the change aligns with linked issue #1336's requirements for whitelisting/testing mechanisms

Possibly related PRs

Suggested reviewers

  • outerlook
  • williamrusdyputra

Poem

🐰 No more base64 in the way,
Raw bytes hop along today,
Attestations test with glee,
Encoding stripped, now pure and free! 🎪

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fixbytea

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a81c255 and fb0775e.

📒 Files selected for processing (1)
  • src/contracts-api/attestationAction.ts (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@holdex
Copy link
Copy Markdown

holdex bot commented Nov 7, 2025

Time Submission Status

Member Status Time Action Last Update
@MicBun ❌ Missing - ⚠️ Submit time -

@MicBun MicBun changed the title chore: make list_attestations example fix: view list_attestations on example Nov 7, 2025
@MicBun MicBun merged commit 80f2be6 into main Nov 7, 2025
2 of 5 checks passed
@MicBun MicBun deleted the fixbytea branch November 7, 2025 11:29
@holdex
Copy link
Copy Markdown

holdex bot commented Nov 7, 2025

Bug Report Checklist

Status Commit Link Bug Author
❌ Not Submitted

@MicBun, please use git blame and specify the link to the commit link that has introduced this bug.

Send the following message in this PR: `@pr-time-tracker bug commit <commit-url> && bug author @name`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant