Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minify-html and minify-js #676

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

cormacrelf
Copy link
Contributor

Fixes build issues related to wilsonzlin/minify-html#166. In particular, building trunk was failing completely under Nix, which disallows internet access during builds.

Technically would have been solved just by updating minify-html, but the two packages are from the same author. So whatever, why not.

@ctron ctron merged commit c2d246f into trunk-rs:main Jan 17, 2024
5 checks passed
@ctron ctron added this to the 0.18.6 milestone Jan 17, 2024
@cormacrelf cormacrelf deleted the feature/bump-minify-html branch January 17, 2024 08:52
@cormacrelf cormacrelf restored the feature/bump-minify-html branch January 17, 2024 08:52
@ctron
Copy link
Collaborator

ctron commented Jan 17, 2024

@cormacrelf I had to revert this PR, because it breaking the output:

11:06:15.934 Uncaught (in promise) ReferenceError: arguments is not defined
    __wbg_self_1ff1d729e9aae938 http://localhost:8080/vanilla-example-780a9119b3b690a7.js:3
    y http://localhost:8080/vanilla-example-780a9119b3b690a7.js:3
    A http://localhost:8080/vanilla-example-780a9119b3b690a7.js:3
    async* http://localhost:8080/:1
vanilla-example-780a9119b3b690a7.js:3:1653
    A http://localhost:8080/vanilla-example-780a9119b3b690a7.js:3
    AsyncFunctionNext self-hosted:852
    (Async: async)
    <anonymous> http://localhost:8080/:1

There's also the thing that it pulls in lighteningcss, which currently is only released as a pre-release. That might also become an issue, but unless someone touches the Cargo.lock file, that should hold. Still I think it's far from optimal.

@ctron
Copy link
Collaborator

ctron commented Jan 17, 2024

I raised an issue for the lighteningcss release: parcel-bundler/lightningcss#662

@ctron
Copy link
Collaborator

ctron commented Jan 17, 2024

I played a bit with that … it looks like minify-js is the problem. 0.5.x works, while 0.6.0 doesn't.

@cormacrelf
Copy link
Contributor Author

Sorry for adding unnecessary bumps to the PR that broke it! "Why not" indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants