Use original artifact name when generating intermediate files #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, there's a problem with this approach: the "wasm name" in used in the loader JS script created by wasm-bindgen. So it needs to know the name of the hashed wasm file. |
|
On the other hand, we provide the name when loading. |
ctron
force-pushed
the
feature/fix_659_1
branch
from
235508d to
b444428
Compare
Using the hashed name will lead to a lot of intermediate files which need cleanup. Without really serving much purpose, as the files will never be re-used. Closes: trunk-rs#659
ctron
force-pushed
the
feature/fix_659_1
branch
from
b444428 to
1dc6d7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the hashed name will lead to a lot of intermediate files which need cleanup. Without really serving much purpose, as the files will never be re-used.
Closes: #659