Use Serialized Key Length for Serialization outputs #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-nitrokey
requested changes
Mar 4, 2025
There was a problem hiding this comment.
If we use SerializedKey directly instead of the constant, this should work before and after trussed-dev/trussed#200.
Co-authored-by: Robin Krahl <[email protected]>
Co-authored-by: Robin Krahl <[email protected]>
Co-authored-by: Robin Krahl <[email protected]>
|
@KyleKotowick Looks good, thank you! Can you please squash the changes into the original commit? |
|
When you merge the PR, you can just choose "Squash Merge", no? |
|
You are right, a squash merge would work in this case, but generally we try to avoid it to keep the structure of multi-commit PRs intact and to keep the signatures on the commits. Anyway, please rebase onto main to fix the CI. |
|
@robin-nitrokey It's now up-to-date with |
|
Merged via #19. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.