feat: upgrade to USWDS 3.8.2 #3263
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, headers need to be in a certain DOM context to avoid a11y issues, and this is how USWDS does it
also matches uswds implementation, fixed tests
…uswds into an-storybooka11y-fixes
- Make tooltip content hoverable - Make tooltip dismissible with escape key
- Fix my incorrect merge in radio stories that removed the Default component - Undo label changes to checkboxes
mdmower-csnw
changed the title
In stories, restore centering of "Go back" (and related) plain text buttons in modals by changing display to `inline-block`, as it was prior to USWDS 3.8.0.
USWDS unstyled buttons result in appearance differences from link-based pagination. This is especially true for hover styles. Use regular `<button>` with minimal utility styles to more closely resemble link-based pagination.
Contributor
Author
|
@jpandersen87 @brandonlenz (and cc: @werdnanoslen just in case you are still active in the project) - Would you be willing to review this changeset? I think it'd be best to increment USWDS one or two minor versions at a time, rather than trying to jump to the latest revision. Plus, @werdnanoslen had this 3.8 update largely done and it would be nice to respect his contribution. EDIT: FYI, I've started work on 3.9 (#3264), 3.10 (#3265), and 3.11+3.12+3.13 (#3266). |
Contributor
Author
|
@crwallace - I just noticed you are listed as the active maintainer for this project in the readme. Are you able to help with reviews? Thanks! I've also started work on 3.9 (#3264), 3.10 (#3265), and 3.11+3.12+3.13 (#3266). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #2848 by @werdnanoslen since it doesn't look like additional movement is expected there.
Summary
These are the features released by USWDS in 3.8.0, 3.8.1, and 3.8.2:
text-centertoflex-justify-centersincedisplayfor buttons changed frominline-blocktoinline-flexin USWDS - Button: Add basic support for usa-icon in buttons uswds/uswds#5398.<button>instead of<Button unstyled>to avoid style conflicts betweenusa-button--unstyledandusa-pagination__buttonclasses (notably, hover styles). Apply minimal utility classes to align styles with link-based pagination.No action needed to support
$theme-table-background-color. It has been verified working by temporarily setting$theme-table-background-color: 'primary-vivid'insrc/styles/_uswds-theme.scssand then rebuilding USWDS (yarn build:uswds) followed by running the storybook (yarn storybook).Related Issues or PRs
Supersedes #2848 and #2962.
How To Test
Confirm things work the same as described in USWDS release notes: 3.8.0, 3.8.1, and 3.8.2.
Happo differences
displaychanging frominline-blocktoinline-flexin USWDS - Button: Add basic support for usa-icon in buttons uswds/uswds#5398. Opting to allow changes.