fix: aws_region.current.name is deprecated

[esacteksab]

When using this module with AWS Provider 6.3.0, I encounter an error

│ Warning: Deprecated attribute
│
│   on .terraform/modules/app_ecs_service/main.tf line 58, in locals:
│   58:             "awslogs-region"        = data.aws_region.current.name
│
│ The attribute "name" is deprecated. Refer to the provider documentation for details.
│
│ (and 2 more similar warnings elsewhere)

This was deprecated with 6.0.0.

I will cut a new major version v8.0.0.

[esacteksab]

https://registry.terraform.io/providers/hashicorp/aws/6.0.0/docs/data-sources/region#name-3

[esacteksab]

Given the deprecation, I'm setting 6.0+ here.

[melissathai]

Changes LGTM, but let's see what @clint-truss thinks since OHS relies on this module.

[clint-truss]

Had one question. I haven't finished the review - had to step into a meeting. Did any other variables change their defaults? It's hard to tell with the re-order.

[clint-truss]

I'm curious as to the rationale for this change. The default setting for this attribute is "DISABLED" per the TF docs. Why set it to ""?
Docs: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ecs_service#availability_zone_rebalancing-1

[esacteksab]

I think it's the way the diff is presenting the tfsort But you set this value in this commit and it's reflected here

[esacteksab]

Not sure if this view helps support this.

[esacteksab]

Had one question. I haven't finished the review - had to step into a meeting. Did any other variables change their defaults? It's hard to tell with the re-order.

I changed no values. I simply did a tfsort.

[clint-truss]

Had one question. I haven't finished the review - had to step into a meeting. Did any other variables change their defaults? It's hard to tell with the re-order.

I changed no values. I simply did a tfsort.

Oh ok, then it just looked that way in the diff. Thanks for the update!