Update module go.yaml.in/yaml/v2 to v3#960
Open
red-hat-konflux[bot] wants to merge 1 commit into
Open
Conversation
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Go module dependency from go.yaml.in/yaml/v2 v2.4.4 to go.yaml.in/yaml/v3 v3.0.4 in go.mod, consolidating on the v3 YAML API. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The go.mod now lists
go.yaml.in/yaml/v3 v3.0.4twice (once replacing v2 and once existing), so you can remove the duplicate entry or rungo mod tidyto let Go clean it up automatically. - Since
go.yaml.in/yaml/v2was a different module path than/v3, double-check that all imports in the codebase now use the/v3path so the old module is no longer implicitly required.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The go.mod now lists `go.yaml.in/yaml/v3 v3.0.4` twice (once replacing v2 and once existing), so you can remove the duplicate entry or run `go mod tidy` to let Go clean it up automatically.
- Since `go.yaml.in/yaml/v2` was a different module path than `/v3`, double-check that all imports in the codebase now use the `/v3` path so the old module is no longer implicitly required.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v2.4.4→v3.0.4Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
yaml/go-yaml (go.yaml.in/yaml/v2)
v3.0.4Compare Source
v3.0.3Compare Source
v3.0.2Compare Source
v3.0.1Compare Source
v3.0.0Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.