Update module github.com/MakeNowJust/heredoc to v2#967
Open
red-hat-konflux[bot] wants to merge 1 commit into
Open
Update module github.com/MakeNowJust/heredoc to v2#967red-hat-konflux[bot] wants to merge 1 commit into
red-hat-konflux[bot] wants to merge 1 commit into
Conversation
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the heredoc dependency from v1 to v2 and adjusts the Go module import path to the v2 module path, aligning go.mod with the upstream module’s v2 release requirements. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since heredoc v2 changes whitespace handling and the import path, double-check any direct or transitive usage in this repo to ensure imports are updated to
github.com/MakeNowJust/heredoc/v2and that behavior relying on trimming or formatting whitespace still works as expected.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since heredoc v2 changes whitespace handling and the import path, double-check any direct or transitive usage in this repo to ensure imports are updated to `github.com/MakeNowJust/heredoc/v2` and that behavior relying on trimming or formatting whitespace still works as expected.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v1.0.0→v2.0.1Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
MakeNowJust/heredoc (github.com/MakeNowJust/heredoc)
v2.0.1Compare Source
Version 2.0.1
Fixes
importpath for Go modulesv2.0.0Compare Source
Version 2.0.0
Breaking Changes
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.