This repository was archived by the owner on Sep 11, 2025. It is now read-only.
global.setup: rename test as setup#29
Merged
carlosthe19916 merged 1 commit intotrustification:mainfrom Mar 11, 2025
Merged
Conversation
When importing `test` into for global setup, for clarity and consistency, rename it to `setup` as is recommended in docs/guides[^1]. In case of teardown we have this renaming already there. [^1]: https://playwright.dev/docs/test-global-setup-teardown#setup
carlosthe19916
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When importing
testinto for global setup, for clarity and consistency,rename it to
setupas is recommended in docs/guides1.In case of teardown we have this renaming already there.
Footnotes
https://playwright.dev/docs/test-global-setup-teardown#setup ↩