Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

License export v2 updates#39

Merged
mrrajan merged 2 commits intotrustification:mainfrom
mrrajan:license_export_v2
Apr 2, 2025
Merged

License export v2 updates#39
mrrajan merged 2 commits intotrustification:mainfrom
mrrajan:license_export_v2

Conversation

@mrrajan
Copy link
Copy Markdown
Collaborator

@mrrajan mrrajan commented Mar 24, 2025

Feature file updates for TPA V2 design changes.
JIRA: TC-2176

Signed-off-by: Rajan Ravi <rravi@rravi-thinkpadp1gen4i.bengluru.csb>
Copy link
Copy Markdown
Collaborator

@queria queria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline - there may be one issue with namespace != documentNamespace in spdx sbom json. So please confirm if it is correct.

Aside that it looks good to me.


One suggestion to think about for future:

I wonder if it would not be better to hide some of the exact column-to-sbom-property mapping details in implementation instead of having it exposed at feature-file level.

While it is nice to see the exact expected mapping details here in the Scenario,
it also makes it quite hard to follow/review (seems overwhelming with details to me).

Maybe there could be later bit more highlevel mapping/description instead, in more generic way like And each package license row values match cdx sbom (and leave the assert/matching of 'cve.name' == 'metadata.component.name' or such up to that steps implementation).
Or maybe it could be defined outside/above the scenario in some table-like format,
and scenario steps only reference that mapping?

Comment thread tests/ui/features/licenseexport_spdx.feature Outdated
Comment thread tests/ui/features/licenseexport_spdx.feature Outdated
@mrrajan
Copy link
Copy Markdown
Collaborator Author

mrrajan commented Apr 1, 2025

@queria I am completely agree with you - but the scenarios are mostly one on one mapping for the SBOM to exported file and differs based on the SBOM format as well. So, I kept bit descriptive. Please let me know.

@matejnesuta matejnesuta self-requested a review April 1, 2025 20:10
Copy link
Copy Markdown
Collaborator

@matejnesuta matejnesuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mrrajan mrrajan merged commit e1d585c into trustification:main Apr 2, 2025
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants