This repository was archived by the owner on Sep 11, 2025. It is now read-only.
ui/search: CVEs to Vulnerabilities, tabs, multiple Downloads#49
Closed
queria wants to merge 3 commits intotrustification:mainfrom
Closed
ui/search: CVEs to Vulnerabilities, tabs, multiple Downloads#49queria wants to merge 3 commits intotrustification:mainfrom
queria wants to merge 3 commits intotrustification:mainfrom
Conversation
Update Search scenario to match implementation in trustify v2. Main point is the CVEs are labeled Vulnerabilities instead. Also there is currently: - not a single list of results but still tabs by type - download links is instead menu with one or more links inside There was mistake with mixed up 'Example' blocks between/after scenarios outlines: - User toggles the <types> list and manipulates the list - Download Links on the <types> Search Result list so while updating them moved the example block to correct place. Related to: TC-2191
queria
force-pushed
the
search-cve-vulnerability
branch
from
1219971 to
8ccff45
Compare
matejnesuta
reviewed
Apr 28, 2025
Collaborator
matejnesuta
left a comment
matejnesuta
left a comment
There was a problem hiding this comment.
Honestly, I would close this PR instead of merging. I have done almost identical changes to the Gherkin during work on UI automation and I think this could cause unnecessary merge conflitcs.
Collaborator
Author
|
I see, so this change can be ignored, expected to be covered by PR #66 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Search scenario to match implementation in trustify v2.
Main point is the CVEs are labeled Vulnerabilities instead.
Also there is currently:
There was mistake with mixed up 'Example' blocks
between/after scenarios outlines:
Related to: TC-2191