This repository was archived by the owner on Sep 11, 2025. It is now read-only.
Sorting of vulnerability table#52
Merged
mrrajan merged 5 commits intotrustification:mainfrom Jul 28, 2025
Merged
Conversation
Signed-off-by: mrrajan <86094767+mrrajan@users.noreply.github.com.>
Signed-off-by: mrrajan <86094767+mrrajan@users.noreply.github.com.>
Signed-off-by: mrrajan <86094767+mrrajan@users.noreply.github.com.>
mrrajan
changed the title
vobratil
suggested changes
Jun 30, 2025
Contributor
vobratil
left a comment
vobratil
left a comment
There was a problem hiding this comment.
I've left some comments and suggestions. Good job with breaking up the code in ToolbarTable.ts into methods! The only change that is, in my opinion, critical is the dedicatedSearch method header. The rest, I'd say, is for your consideration.
tests/ui/features/@vulnerability-explorer/vulnerability-explorer.step.ts
Show resolved
Hide resolved
Signed-off-by: mrrajan <86094767+mrrajan@users.noreply.github.com.>
Signed-off-by: mrrajan <86094767+mrrajan@users.noreply.github.com.>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors existing keywords for better clarity and implements a reusable sorting mechanism.