Skip to content

test: create more tests for image_index #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test: create more tests for image_index #1398

wants to merge 1 commit into from

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Mar 5, 2025

No description provided.

@ctron ctron requested a review from JimFuller-RedHat March 5, 2025 14:40
JimFuller-RedHat
JimFuller-RedHat approved these changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@JimFuller-RedHat JimFuller-RedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might consider adding document_id to the test assert as that is the main (stable) indicator) when we transition to external document in the returned REST API results, otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimFuller-RedHat JimFuller-RedHat JimFuller-RedHat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctron @JimFuller-RedHat