Skip to content

chore: ignore spans shorter than 1ms #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

chore: ignore spans shorter than 1ms #1635

merged 1 commit into from
May 19, 2025

Conversation

helio-frota
Copy link
Collaborator

before:

2025-05-15_14-04

after:

2025-05-15_16-39

@helio-frota helio-frota linked an issue May 15, 2025 that may be closed by this pull request
Second round of OTEL - traces and metrics #1308
Closed
@helio-frota helio-frota requested a review from dejanb May 16, 2025 09:48
@helio-frota
Copy link
Collaborator Author

I think we have some ways to solve that issue with functions shorter than 1ms:

  • Remove the #[instrument] macro from the function (easy and intrusive)
  • Create a custom spanExporter in rust (hard and I already spent ~2 hours yesterday with no success (also can be impacted with the evolution of otel-rust apis) )
  • Delegate that to collector (easy and we are using the collector anyway so why not)

@helio-frota helio-frota added this pull request to the merge queue May 19, 2025
Merged via the queue into trustification:main with commit 6732754 May 19, 2025
4 checks passed
@helio-frota helio-frota deleted the task branch May 19, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dejanb dejanb dejanb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Second round of OTEL - traces and metrics
2 participants
@helio-frota @dejanb