feat(twt): add CoinMarketCap link to TWT token info#35658
feat(twt): add CoinMarketCap link to TWT token info#35658
Conversation
Add CoinMarketCap link (https://coinmarketcap.com/currencies/trust-wallet-token/) to TWT token info.json on BSC, Binance Chain, and Solana. Also adds missing X (Twitter) and Reddit links to the BSC entry for consistency with other chains. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No token files found. If you try to add/modify a token, check the name and location of your files! Logo file must be named exactly 'logo.png'. If you are not adding a token, ignore this message. |
tw-jt
left a comment
tw-jt
left a comment
There was a problem hiding this comment.
Code Review Summary
P0 — Must Fix
None
P1 — Should Fix
None
P2 — Consider
- Pre-existing GitHub URL inconsistency: The Binance Chain entry (
TWT-8C2/info.json) useshttps://github.com/trustwallet(no trailing slash) while BSC and Solana entries usehttps://github.com/trustwallet/(with trailing slash). This is not introduced by this PR — it existed before. Not blocking.
Fixes Applied
None needed — PR is clean.
Verification Performed
- JSON validity: All 3 modified files parse as valid JSON.
- Schema consistency: All link objects follow the existing
{"name": "...", "url": "..."}pattern used throughout the repo. - URL format: The
coinmarketcaplink name and URL format (https://coinmarketcap.com/currencies/trust-wallet-token/) match the convention used by other tokens (e.g., FDUSD, WETH, DAI). - Coverage: All 3 TWT entries across chains (BSC, Binance Chain, Solana) were updated — no chains missed.
- Link consistency: After the PR, all 3 entries have the same link set:
github,x,reddit,coinmarketcap. - BSC normalization: The BSC entry previously only had a
githublink. Addingx,reddit, andcoinmarketcapbrings it in line with the Binance Chain and Solana entries — good consistency improvement. - No trailing newline: Files don't end with a newline, consistent with the original files and repo convention.
Overall Assessment
Clean, minimal PR that adds the requested CoinMarketCap link to all TWT token entries and normalizes social links on the BSC entry. No bugs, no security concerns, no performance impact. Changes are purely additive data entries in static JSON files.
Reviewed by Conductor Review Agent
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No token files found. If you try to add/modify a token, check the name and location of your files! Logo file must be named exactly 'logo.png'. If you are not adding a token, ignore this message. |
…tests coin.BINANCE, coin.SMARTCHAIN, and coin.SOLANA are untyped int constants that cannot be used as coin.Coin struct values. Replace with constructor functions coin.Binance(), coin.Smartchain(), and coin.Solana() to match the expected type signature. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No token files found. If you try to add/modify a token, check the name and location of your files! Logo file must be named exactly 'logo.png'. If you are not adding a token, ignore this message. |
1 similar comment
|
No token files found. If you try to add/modify a token, check the name and location of your files! Logo file must be named exactly 'logo.png'. If you are not adding a token, ignore this message. |
- Remove unused intPtr helper function (deadcode lint error) - Add period to comment ending (godot lint error) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No token files found. If you try to add/modify a token, check the name and location of your files! Logo file must be named exactly 'logo.png'. If you are not adding a token, ignore this message. |
- Consolidate TestSpamTokenInfoJSON subtests to stay under funlen limit
- Compact TestValidateLinks_AllLinkTypes test cases to stay under funlen limit
- Use nil instead of []Link{} to satisfy gofmt -s
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No token files found. If you try to add/modify a token, check the name and location of your files! Logo file must be named exactly 'logo.png'. If you are not adding a token, ignore this message. |
1 participant
Summary
Changes
blockchains/smartchain/assets/0x4B0F.../info.jsonblockchains/binance/assets/TWT-8C2/info.jsonblockchains/solana/assets/HZNpq.../info.jsonDatabase Changes
None
Testing
Rollback Plan
Revert this single commit to restore the previous info.json files.
🤖 Generated with Claude Code