Return providers as list & conditionally enable remote based on installed deps.#37
Merged
dmaniloff merged 4 commits intotrustyai-explainability:mainfrom Oct 17, 2025
Conversation
- Added constants for provider type and IDs in constants.py. - Updated provider.py to check for remote dependencies and conditionally include remote provider specifications. - Refactored inline and remote provider specifications to utilize the new constants for provider type. - Adjusted test cases to use the new inline provider ID constant.
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `README.md:42` </location>
<code_context>
```
- The sample LS distributions (one for inline and one for remote provider) is a simple LS distribution that uses Ollama for inference and embeddings. See the provider-specific sections below for setup and run commands.
-### Remote provider (default)
</code_context>
<issue_to_address>
**issue (typo):** Grammatical error: 'is' should be 'are' when referring to multiple distributions.
The sentence should use 'are' instead of 'is' to match the plural subject.
```suggestion
- The sample LS distributions (one for inline and one for remote provider) are simple LS distributions that use Ollama for inference and embeddings. See the provider-specific sections below for setup and run commands.
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -41,12 +41,29 @@ There are two versions of the provider: | |||
| ``` | |||
| - The sample LS distributions (one for inline and one for remote provider) is a simple LS distribution that uses Ollama for inference and embeddings. See the provider-specific sections below for setup and run commands. | |||
Contributor
There was a problem hiding this comment.
issue (typo): Grammatical error: 'is' should be 'are' when referring to multiple distributions.
The sentence should use 'are' instead of 'is' to match the plural subject.
Suggested change
| - The sample LS distributions (one for inline and one for remote provider) is a simple LS distribution that uses Ollama for inference and embeddings. See the provider-specific sections below for setup and run commands. | |
| - The sample LS distributions (one for inline and one for remote provider) are simple LS distributions that use Ollama for inference and embeddings. See the provider-specific sections below for setup and run commands. |
ruivieira
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Return providers as a list and enable the remote evaluation provider only when its dependencies are available, backed by updated configuration, shared constants, demo notebooks, documentation, and tests.
New Features:
Enhancements:
Build:
Documentation:
Tests: