Skip to content

Return providers as list & conditionally enable remote based on installed deps.#37

Merged
dmaniloff merged 4 commits intotrustyai-explainability:mainfrom
dmaniloff:return-providers-as-list
Oct 17, 2025
Merged

Return providers as list & conditionally enable remote based on installed deps.#37
dmaniloff merged 4 commits intotrustyai-explainability:mainfrom
dmaniloff:return-providers-as-list

Conversation

@dmaniloff
Copy link
Copy Markdown
Collaborator

@dmaniloff dmaniloff commented Oct 17, 2025

Summary by Sourcery

Return providers as a list and enable the remote evaluation provider only when its dependencies are available, backed by updated configuration, shared constants, demo notebooks, documentation, and tests.

New Features:

  • Return multiple provider specifications as a list from get_provider_spec
  • Conditionally enable remote provider only when optional dependencies are installed

Enhancements:

  • Introduce constants for provider IDs and types
  • Simplify distribution configuration to a single run.yaml using environment-based conditional provider inclusion
  • Update demo notebooks to use provider list, pandas comparison, and unified dataset/benchmark identifiers
  • Refactor provider modules to use shared constants and import inline implementation by default

Build:

  • Bump project version to 0.4.1

Documentation:

  • Revise README to clarify inline vs remote provider installation and usage

Tests:

  • Update integration tests to use new provider ID constants

- Added constants for provider type and IDs in constants.py.
- Updated provider.py to check for remote dependencies and conditionally include remote provider specifications.
- Refactored inline and remote provider specifications to utilize the new constants for provider type.
- Adjusted test cases to use the new inline provider ID constant.
@trustyai-explainability trustyai-explainability deleted a comment from sourcery-ai bot Oct 17, 2025
@dmaniloff dmaniloff changed the title Return-providers-as-list Return providers as list & conditionally enable remote based on installed deps. Oct 17, 2025
@dmaniloff dmaniloff marked this pull request as ready for review October 17, 2025 16:36
@dmaniloff dmaniloff requested a review from ruivieira October 17, 2025 16:36
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `README.md:42` </location>
<code_context>
     ```
 - The sample LS distributions (one for inline and one for remote provider) is a simple LS distribution that uses Ollama for inference and embeddings. See the provider-specific sections below for setup and run commands.

-### Remote provider (default)
</code_context>

<issue_to_address>
**issue (typo):** Grammatical error: 'is' should be 'are' when referring to multiple distributions.

The sentence should use 'are' instead of 'is' to match the plural subject.

```suggestion
- The sample LS distributions (one for inline and one for remote provider) are simple LS distributions that use Ollama for inference and embeddings. See the provider-specific sections below for setup and run commands.
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -41,12 +41,29 @@ There are two versions of the provider:
```
- The sample LS distributions (one for inline and one for remote provider) is a simple LS distribution that uses Ollama for inference and embeddings. See the provider-specific sections below for setup and run commands.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (typo): Grammatical error: 'is' should be 'are' when referring to multiple distributions.

The sentence should use 'are' instead of 'is' to match the plural subject.

Suggested change
- The sample LS distributions (one for inline and one for remote provider) is a simple LS distribution that uses Ollama for inference and embeddings. See the provider-specific sections below for setup and run commands.
- The sample LS distributions (one for inline and one for remote provider) are simple LS distributions that use Ollama for inference and embeddings. See the provider-specific sections below for setup and run commands.

@dmaniloff dmaniloff merged commit 0b1cbf3 into trustyai-explainability:main Oct 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants