Use stock python image for KFP & add package installation to components.#49
Merged
dmaniloff merged 3 commits intotrustyai-explainability:mainfrom Dec 18, 2025
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideSwitches Kubeflow components to use a stock UBI Python 3.12 base image and ensures the Ragas provider package is installed at runtime via Kubeflow’s packages_to_install mechanism. Sequence diagram for Kubeflow component startup with packages_to_installsequenceDiagram
participant KFP as KubeflowPipelines
participant K8s as Kubernetes
participant Pod as ComponentPod
participant ImgReg as UBI_Python_Image_Registry
participant Pip as PipInstaller
participant Comp as ComponentCode
KFP->>K8s: Create Pod for retrieve_data_from_llama_stack
KFP->>K8s: Create Pod for run_ragas_evaluation
K8s->>ImgReg: Pull DEFAULT_RAGAS_PROVIDER_IMAGE
ImgReg-->>K8s: UBI Python 3.12 image
K8s-->>Pod: Start container with base_image
Pod->>Pip: Install packages_to_install
Pip-->>Pod: llama-stack-provider-ragas[remote] installed
Pod->>Comp: Execute component entrypoint
Comp-->>KFP: Component task completes
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The
packages_to_install=["llama-stack-provider-ragas[remote]"]list is duplicated across components; consider extracting it into a shared constant to avoid drift if it ever changes. - Using
:latestfor theDEFAULT_RAGAS_PROVIDER_IMAGEreduces reproducibility of Kubeflow runs; consider pinning to a specific image tag or digest instead.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `packages_to_install=["llama-stack-provider-ragas[remote]"]` list is duplicated across components; consider extracting it into a shared constant to avoid drift if it ever changes.
- Using `:latest` for the `DEFAULT_RAGAS_PROVIDER_IMAGE` reduces reproducibility of Kubeflow runs; consider pinning to a specific image tag or digest instead.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…image and clarify usage.
ruivieira
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a stock Python image and install the provider package. This avoid having to maintain a custom image.
Image references:
Add Python 3.12 UBI image reference opendatahub-io/ODH-Build-Config#19Operator update: