Add e2e test environment setup scripts and configuration files#59
Merged
dmaniloff merged 1 commit intotrustyai-explainability:mainfrom Feb 26, 2026
Merged
Conversation
This commit introduces a comprehensive setup for the llama-stack-provider-ragas e2e test environment, including: - A Containerfile for building the test image. - Deployment and teardown scripts for managing the test environment on OpenShift. - Configuration files for Kubernetes resources, including ConfigMaps, Secrets, and DataSciencePipelinesApplication manifests. - MinIO deployment for results storage and necessary operator configurations. These additions facilitate automated testing and deployment of the llama-stack provider in a Kubernetes environment.
Contributor
Reviewer's GuideAdds a complete OpenShift-based e2e test environment for llama-stack-provider-ragas, including a buildable test image, deployment/teardown scripts, LlamaStackDistribution config, Open Data Hub / DSPA / Kubeflow integration, and a MinIO-backed S3-compatible results store wired into the provider config. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In deploy-e2e.sh, consider adding more robust handling/logging for timeouts (e.g., printing current conditions or relevant events for DSC/DSPA/operator resources) to make diagnosing failures easier when a wait loop exits with an error.
- Several manifests hard-code the ragas-test namespace and fixed resource names (e.g., DataSciencePipelinesApplication, MinIO, LlamaStackDistribution); if you expect to run multiple environments or reuse these manifests, parameterizing namespace and names via kustomize or envsubst would make the setup more flexible.
- MinIO and mc images are pinned to
:latestand use fixed default credentials (minioadmin); for reproducibility and security in long‑lived clusters, it would be better to pin explicit versions and, where feasible, allow overriding credentials via secrets or environment variables rather than inlined values.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In deploy-e2e.sh, consider adding more robust handling/logging for timeouts (e.g., printing current conditions or relevant events for DSC/DSPA/operator resources) to make diagnosing failures easier when a wait loop exits with an error.
- Several manifests hard-code the ragas-test namespace and fixed resource names (e.g., DataSciencePipelinesApplication, MinIO, LlamaStackDistribution); if you expect to run multiple environments or reuse these manifests, parameterizing namespace and names via kustomize or envsubst would make the setup more flexible.
- MinIO and mc images are pinned to `:latest` and use fixed default credentials (`minioadmin`); for reproducibility and security in long‑lived clusters, it would be better to pin explicit versions and, where feasible, allow overriding credentials via secrets or environment variables rather than inlined values.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
m-misiura
approved these changes
Feb 26, 2026
dmaniloff
added a commit
to dmaniloff/llama-stack-provider-ragas
that referenced
this pull request
Mar 12, 2026
These files were superseded by tests/cluster-deployment/ in PR trustyai-explainability#59. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a comprehensive setup for the llama-stack-provider-ragas e2e test environment, including:
These additions facilitate automated testing and deployment of the llama-stack provider in a Kubernetes environment.
Summary by Sourcery
Add automation and Kubernetes resources to provision an OpenShift-based e2e test environment for the llama-stack-provider-ragas distribution, including image build, deployment, and teardown.
New Features:
Tests: