Skip to content

Commit e80b92e

Browse files
authored
Merge pull request #731 from trustyai-explainability/fix/kserve-v17-standard-deployment-mode
fix(tas): handle KServe v0.17 Standard and KNative deployment modes
2 parents d4d151a + 21b98e4 commit e80b92e

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

controllers/tas/inference_services.go

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ import (
1818
const (
1919
DEPLOYMENT_MODE_MODELMESH = "ModelMesh"
2020
DEPLOYMENT_MODE_RAW = "RawDeployment"
21+
DEPLOYMENT_MODE_STANDARD = "Standard"
2122
DEPLOYMENT_MODE_SERVERLESS = "Serverless"
23+
DEPLOYMENT_MODE_KNATIVE = "Knative"
2224
)
2325

2426
// GetDeploymentsByLabel returns a list of Deployments that match a label key-value pair
@@ -243,17 +245,17 @@ func (r *TrustyAIServiceReconciler) handleInferenceServices(ctx context.Context,
243245
}
244246
continue
245247

246-
case DEPLOYMENT_MODE_RAW:
247-
// Handle KServe Raw deployments
248+
case DEPLOYMENT_MODE_RAW, DEPLOYMENT_MODE_STANDARD:
249+
// Handle KServe Raw/Standard deployments (KServe v0.17+ renamed RawDeployment to Standard)
248250
err := r.patchKServe(ctx, instance, infService, namespace, crName, remove, true)
249251
if err != nil {
250252
log.FromContext(ctx).Error(err, "Could not patch InferenceLogger for KServe Raw deployment")
251253
return false, err
252254
}
253255
continue
254256

255-
default:
256-
// Handle KServe Serverless deployments
257+
case DEPLOYMENT_MODE_SERVERLESS, DEPLOYMENT_MODE_KNATIVE:
258+
// Handle KServe Serverless/Knative deployments (KServe v0.17+ renamed Serverless to Knative)
257259
if kServeServerlessEnabled {
258260
err := r.patchKServe(ctx, instance, infService, namespace, crName, remove, false)
259261
if err != nil {
@@ -262,6 +264,10 @@ func (r *TrustyAIServiceReconciler) handleInferenceServices(ctx context.Context,
262264
}
263265
}
264266
continue
267+
268+
default:
269+
log.FromContext(ctx).Info("Unknown deployment mode, skipping InferenceService", "deploymentMode", deploymentMode, "inferenceService", infService.Name)
270+
continue
265271
}
266272
}
267273
return true, nil

0 commit comments

Comments
 (0)