Repository navigation
Brand marks inline: agent, editor, provider marks, ExternalAgentMark, ModelBadge family (ATL-905) - #10
Merged
Conversation
…rk, ModelBadge family - brand-marks: ClaudeCodeMark, CodexMark, CursorAgentMark, KiloMark, ZedMark, JetBrainsMark; OpenCodeMark and the agent/editor marks title themselves (title="" makes one decorative) through a private lib/brand-mark-svg frame - provider-marks (new): the 19 BYOK provider marks plus Qwen, Kimi, Meta and Zhipu, path data copied from Lobe Icons 5.16.0 with no dependency on it; exempt from the ratchet as third-party trademarks - agent-icon (new): ExternalAgentMark (mask for currentColor registry icons, image otherwise), AgentMonogram, monogramTextClass - model-badge: ModelFamily exported, ModelBadge takes family (null = no mark) - gradual-blur: GradualBlurProps exported - THIRD_PARTY_NOTICES: Lobe Icons, Simple Icons, desktop agent marks, trademarks - tests for all five, stories for marks, provider marks, agent icon, badge, blur
…d as a placeholder, monogram keeps astral characters whole
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATL-905. Every brand mark desktop draws is now inline SVG in the package, so desktop can delete
agent-icons.tsx,editor-icons.tsx,provider-logo.tsxand drop@lobehub/icons(ATL-936).What's in it
brand-marks.tsx: agent marksClaudeCodeMark,CodexMark,CursorAgentMark(Cursor's five-shade cube, its own viewBox),KiloMark(still the placeholder K), and editor marksZedMark,JetBrainsMark. These andOpenCodeMarktitle themselves with the brand name (role="img"+<title>).title=""makes one decorative. The social and model marks are unchanged and stayaria-hidden.provider-marks.tsx(new): the 19 BYOK provider marks, plusQwenMark,KimiMark,MetaMarkandZhipuMark, because desktop's model picker groups by those families through the sameProviderLogo. The paths are byte-for-byte Lobe Icons 5.16.0 (identical in 5.23.1, the version desktop pins), with no dependency on the package. Each mark is titled with Lobe'sTITLEstring. Gradient ids come fromuseId(). OpenAI and Google reuseOpenAIMarkandGoogleMark. OrcaRouter is not ported: it is a PNG with no vector source, so desktop keeps it.agent-icon.tsx(new):ExternalAgentMarkdraws a registry SVG withcurrentColoras a mask and anything else as an<img>; it never injects markup. AlsoAgentMonogramandmonogramTextClass.model-badge.tsx:ModelFamilyis exported.ModelBadgetakesfamily?: ModelFamily | null: a value wins,nulldraws no mark, and when it's omitted the badge guesses from the name.GradualBlurPropsis now exported.lib/brand-mark-svg.tsxis the private frame that carries the title rule; it is not in the barrel.provider-marks.tsx.THIRD_PARTY_NOTICES.mdnow covers Lobe Icons (both files, including the Claude Code and Codex paths), Simple Icons (CC0), the desktop-drawn marks and the trademark sentence.Differences from the issue text
@lobehub/icons.monogramTextClassuses the package's real scale:text-3xs/2xs/xs/base/lg/2xl. The issue'stext-4xsdoesn't exist here and would have rendered nothing.OpenCodeMarkkeeps its token fills and its height-driven width, as it is on main. Desktop's fixed-fill#F1ECEC/#4B4646version is not ported; the token version replaces it in every theme.-g/-r/-ysuffixes. They are still unique per instance.Checks
typecheck, format:check, theme:check, test (133), build, test:consumer, build-storybook, storybook:smoke all pass locally. The new stories were screenshotted in headless Chromium, dark and light.