Skip to content

Brand marks inline: agent, editor, provider marks, ExternalAgentMark, ModelBadge family (ATL-905) - #10

Merged
uzayer merged 2 commits into
mainfrom
ds-905-marks
Nov 4, 2026
Merged

uzayer merged 2 commits into
mainfrom
ds-905-marks

Conversation

@uzayer

@uzayer uzayer commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

ATL-905. Every brand mark desktop draws is now inline SVG in the package, so desktop can delete agent-icons.tsx, editor-icons.tsx, provider-logo.tsx and drop @lobehub/icons (ATL-936).

What's in it

  • brand-marks.tsx: agent marks ClaudeCodeMark, CodexMark, CursorAgentMark (Cursor's five-shade cube, its own viewBox), KiloMark (still the placeholder K), and editor marks ZedMark, JetBrainsMark. These and OpenCodeMark title themselves with the brand name (role="img" + <title>). title="" makes one decorative. The social and model marks are unchanged and stay aria-hidden.
  • provider-marks.tsx (new): the 19 BYOK provider marks, plus QwenMark, KimiMark, MetaMark and ZhipuMark, because desktop's model picker groups by those families through the same ProviderLogo. The paths are byte-for-byte Lobe Icons 5.16.0 (identical in 5.23.1, the version desktop pins), with no dependency on the package. Each mark is titled with Lobe's TITLE string. Gradient ids come from useId(). OpenAI and Google reuse OpenAIMark and GoogleMark. OrcaRouter is not ported: it is a PNG with no vector source, so desktop keeps it.
  • agent-icon.tsx (new): ExternalAgentMark draws a registry SVG with currentColor as a mask and anything else as an <img>; it never injects markup. Also AgentMonogram and monogramTextClass.
  • model-badge.tsx: ModelFamily is exported. ModelBadge takes family?: ModelFamily | null: a value wins, null draws no mark, and when it's omitted the badge guesses from the name.
  • GradualBlurProps is now exported. lib/brand-mark-svg.tsx is the private frame that carries the title rule; it is not in the barrel.
  • The ratchet's EXEMPT list gains exactly one key: provider-marks.tsx.
  • THIRD_PARTY_NOTICES.md now covers Lobe Icons (both files, including the Claude Code and Codex paths), Simple Icons (CC0), the desktop-drawn marks and the trademark sentence.

Differences from the issue text

  • 4 extra provider marks (Qwen, Kimi, Meta, Zhipu). Without them desktop can't drop @lobehub/icons.
  • monogramTextClass uses the package's real scale: text-3xs/2xs/xs/base/lg/2xl. The issue's text-4xs doesn't exist here and would have rendered nothing.
  • OpenCodeMark keeps its token fills and its height-driven width, as it is on main. Desktop's fixed-fill #F1ECEC/#4B4646 version is not ported; the token version replaces it in every theme.
  • The Gemini gradient ids keep their existing -g/-r/-y suffixes. They are still unique per instance.

Checks

typecheck, format:check, theme:check, test (133), build, test:consumer, build-storybook, storybook:smoke all pass locally. The new stories were screenshotted in headless Chromium, dark and light.

…rk, ModelBadge family

- brand-marks: ClaudeCodeMark, CodexMark, CursorAgentMark, KiloMark, ZedMark,
  JetBrainsMark; OpenCodeMark and the agent/editor marks title themselves
  (title="" makes one decorative) through a private lib/brand-mark-svg frame
- provider-marks (new): the 19 BYOK provider marks plus Qwen, Kimi, Meta and
  Zhipu, path data copied from Lobe Icons 5.16.0 with no dependency on it;
  exempt from the ratchet as third-party trademarks
- agent-icon (new): ExternalAgentMark (mask for currentColor registry icons,
  image otherwise), AgentMonogram, monogramTextClass
- model-badge: ModelFamily exported, ModelBadge takes family (null = no mark)
- gradual-blur: GradualBlurProps exported
- THIRD_PARTY_NOTICES: Lobe Icons, Simple Icons, desktop agent marks, trademarks
- tests for all five, stories for marks, provider marks, agent icon, badge, blur
…d as a placeholder, monogram keeps astral characters whole
@uzayer
uzayer merged commit e7c3941 into main Nov 4, 2026
1 check passed
@uzayer
uzayer deleted the ds-905-marks branch November 4, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant