Repository navigation
Merged
Conversation
…attention tones, a hollow shape, a cutout ring and a label It moves out of pill.tsx (same export, same default look) and gains what desktop's capture dot and web's presence dot hand-roll: xs/sm/md/lg, subtle/primary/foreground tones, hollow for the off state, cutout to ring it in the surface under it, and label to make it role=img when it carries the state alone. Unlabelled, it is aria-hidden.
…width, a sliding thumb, sm and md The chosen tab's fill is Base UI's Tabs.Indicator, moving on translate and resizing on width (snapping under reduced motion), in place of a fill on the active tab. TabsList takes size (sm | md, Segmented's two) on the segmented variant; a line rail has no size and no thumb. Semantics are unchanged: a tablist of tabs that own panels. Desktop's share and comment filters hand-roll this today as role=tablist pills.
… theirs TextLink (through LinkProvider) and linkVariants (also on ./variants) are the standalone link: no underline at rest, underlined on hover and keyboard focus, in foreground or muted ink. Button variant="link" gains the focus-visible underline. .prose-session a, which drew a dotted rule only on hover, now underlines at rest in a quieter tint of its ink and in full ink on hover and focus. The README states the rule.
…aceholder K The path data is the docs site's logo.svg from Kilo-Org/kilocode (MIT), unchanged and pinned to commit 8009ffe in the source comment, on its own 100x100 viewBox in currentColor. THIRD_PARTY_NOTICES.md carries the licence and drops the placeholder note.
…ith strictRules on ./ratchet
For web's ATL-863 tests.
PACKAGE_SENTINEL_CLASS is an arbitrary property named only in dist/, so
--tryatlas-design-sentinel: 1 is in a consumer's CSS only if Tailwind
scanned the package. The consumer fixture now asserts on it in both entries.
D23_RENAMES maps each renamed colour name to its { variable, utility }: the
19 standards roles recorded in the README's migration tables, and every
theme key's --atlas- prefix drop, generated from the registry. A test holds
each new name to a declared variable or bridged utility and each old one to
a name the package no longer declares.
defineRatchetSuite registers a consumer's ratchet test from config (root,
roots, rules, exemptions, minFiles, footer) with the runner's describe and
it, throwing formatViolations' message; the package's own suite now uses
it. strictRules is web's extra notch: rounded-[inherit] allowed, no raised
shadows, no [var(--…)], no dark:. RatchetOptions.rules accepts a readonly
array.
Asks for the next page as a sentinel nears the viewport or a given scroller (400px ahead by default), shows the list's skeleton while fetching, an error Callout with a retry on failure (no automatic asking while failed), and nothing once there is no next page. It owns no data: the app's query drives hasNext, fetching, failed and onNext. Generalised from web's shell/next-page.tsx: root and skeleton are optional, failure is any node, and the retry label and root margin are props. onNext is read through a ref, so an inline arrow does not re-observe on every render.
InputGroupInput and InputGroupTextarea opt out of the global :focus-visible ring with focus-ring-none, which drew a second indicator inside the group's own focus border. The group now carries that ring instead (2px of --ring, offset 1px) while its control has keyboard focus, alongside the border's lift to border-strong, so keyboard focus stays as visible as before.
For a face inside a line of text or a dense graph; desktop's commit graph needs both. In px like the ladder, since the app's root font size moves rem; the fallback initials are text-3xs at both.
…link underline rule, Kilo's mark, consumer guards, NextPage, InputGroup's single focus indicator, small avatars; README upgrade notes for 0.1.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eight additive gaps for desktop and web, one commit each, then the 0.1.7 bump with README upgrade notes.
D23_RENAMESholds 19 standards role renames (hairline→border-subtle,success→status-success-foreground, …) plus every theme key's--atlas-prefix drop, generated from the registry.utilityis the class name that replaces<prefix>-<old>. It equals the old name where the package still bridges the old class (text-successworks; only--successmoved), and it isnullwhere no utility exists.Evidence
KiloMarkwas a placeholder K. The segmented TabsList had equal-width tabs with a static fill..prose-session ahad no underline at rest. The InputGroup drew two focus indicators.After: every CI gate passes on the tip:
New tests:
status-dot,tabs(tablist semantics, thumb first, sizes),text-link(rule for TextLink, linkVariants, and Button link; prose underline),brand-marks(Kilo viewBox and frame),d23-renames(each new name is declared or bridged, each old one is gone),design-system-ratchet(strictRules; defineRatchetSuite failure, footer and minFiles; the package's own suite now runs through it),next-page(observe, stable onNext, skeleton, failure and retry, end),input-group,avatar.Merge Danger
Door: two-way
Additive exports plus a few visual changes, all listed under "Upgrading to 0.1.7" in the README. Consumers pin by tag, so nothing moves until they bump.
Blast Radius: visual
TabsListtabs size to their content (they wereflex-1), and the active tab's fill is now a sliding indicator, not a class on the tab. This affects web'satlas/activity.tsxandfacts.tsx.StatusDotwithout alabelis nowaria-hidden. A deep import frompill.tsxbreaks; the root export is unchanged..prose-session ais underlined at rest.InputGroupshows its keyboard ring around the whole group, not inside it.D23_RENAMES. There are 19 role renames plus the prefix drops, each with a{ variable, utility }shape, so that test should filteratlas-*keys and readvariableandutility.