Repository navigation
Desktop gaps: TimelineCalendar measured end, UiScalePanel card, glass popover, IconButton element icon - #24
Merged
Merged
Conversation
A column that puts padding or a note after the calendar in the same scroller made the last day overshoot the sticky date. "measure" subtracts whatever follows the calendar from the end space. true and false are unchanged.
Ring and a small shadow instead of a border (2px shorter), a foreground/8 divider, and foreground/8 / foreground/6 fills for the selected and hovered presets, as desktop's control drew them. Docs and web render the control without restyling it, so they take the desktop look.
Desktop team-chat menus were bg-card/95 under a backdrop blur, rounded-xl, a raised top edge and the dialog-rung shadow. no-restyle keeps call sites to layout and spacing, so it is a surface variant. Uses the one glass blur (backdrop-blur-glass, 24px) rather than desktop's 40px.
A Lucide component still draws through Icon at the square's step. An element draws as given, for a spinning refresh or the package's own glyphs (RailGlyph). Existing callers are unchanged.
# Conflicts: # stories/components/shell/ui-scale.stories.tsx
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small package gaps reported by desktop agents working on ATL-919 and ATL-888. There is no single issue for this work. Each gap is one commit.
TimelineCalendarendSpace="measure"(opt-in).endSpace={true}sizes the trailing space as if the list ends the scroll area. Desktop's Timeline and Inbox columns put apb-32and a note after the list, so the last day scrolled off the top and left an empty column under the wrong date. Desktop passesendSpace={false}today."measure"subtracts whatever the scroller holds after the calendar, so the end stops with the last day under the date. The measurement runs in a layout effect (not on scroll) and with a ResizeObserver on the calendar's parent and the scroller's content box, so a note that rewraps or a sentinel that mounts updates it.trueandfalseare unchanged. Desktop can switch both sites toendSpace="measure".UiScalePanel's inset card matches desktop. It now usesring-1 ring-border shadow-sminstead ofborder border-border, which makes it 2px shorter. The divider isborder-foreground/8and the preset fills arebg-foreground/8/hover:bg-foreground/6. This is a default change, not a variant: docs (sidebar-controls.tsx) rendersUiScaleControlwithout restyling it, and the web app only names it in a plan doc, so nothing depends on the old look.PopoverContent surface="glass"(opt-in): desktop's team-chat menu look,rounded-xl bg-card/95 shadow-lg inset-highlight backdrop-blur-glass. This is the recipe the pinned, new-DM, new-channel, rename-channel and call menus used before ATL-888 moved them onto the package. The blur is the package's one glass blur (24px), not desktop'sbackdrop-blur-2xl(40px). The blur radius never animates, and the docblock says to keep it to small menus.IconButtoniconalso takes an element, drawn as given. Callers can pass a spinning refresh or a package glyph (RailGlyph). A Lucide component still draws throughIconat the square's step, so existing callers are unchanged.Not changed:
bg-terminal-backgroundalready exists. Code surface: editor and terminal chrome (ATL-874) #20 added--color-terminal-backgroundwith the other terminal bridges, andTerminalPaletteuses it.Button size="icon-xs"was not re-added. The README's rename table deliberately mapsButton size="icon"/icon-xs/icon-sm/icon-lgtoIconButton size. ATL-939's needs are covered without it:DOCK_TRIGGER=iconButtonVariants({ variant: "ghost", size: "xs" })(on./variants, 20px), andDockButton=<IconButton size="xs" icon={<RailGlyph … />} />using item 4.Upgrade notes (for the next release)
TimelineCalendartakesendSpace="measure"for a scroller with content after the list.UiScalePanel/UiScaleControl: the inset card is a ring plusshadow-sm(2px shorter), with foreground-tint divider and fills.PopoverContenttakessurface="glass".IconButton'siconaccepts an element as well as a Lucide component.Evidence
test:storybook:Blocks/TimelineCalendarMeasuredEnd: the play scrolls to the end and asserts the last day names the sticky date and its heading lines up within 2px. WithendSpace: truethe same story fails, which is the bug.Shell/UiScalePanel: the play asserts no border and a shadow beyond the ring.Primitives/PopoverGlass: the play asserts a backdrop blur and a radius aboverounded-lg.Primitives/IconButtonElementIcon.typecheck,format:check,theme:check,test(448 passed),test:storybook(692 passed, axe included),test:consumer(ok),build-storybook,storybook:smoke(692 stories).atlas-work/shots/ds-gaps-018/.Merge Danger
UiScalePanellooks. That is intended (desktop is the source of truth) and applies to docs' rail control on its next pin bump.