Skip to content

Desktop gaps: TimelineCalendar measured end, UiScalePanel card, glass popover, IconButton element icon - #24

Merged
uzayer merged 5 commits into
mainfrom
ds-gaps-018
Nov 4, 2026
Merged

uzayer merged 5 commits into
mainfrom
ds-gaps-018

Conversation

@uzayer

@uzayer uzayer commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

Small package gaps reported by desktop agents working on ATL-919 and ATL-888. There is no single issue for this work. Each gap is one commit.

  1. TimelineCalendar endSpace="measure" (opt-in). endSpace={true} sizes the trailing space as if the list ends the scroll area. Desktop's Timeline and Inbox columns put a pb-32 and a note after the list, so the last day scrolled off the top and left an empty column under the wrong date. Desktop passes endSpace={false} today. "measure" subtracts whatever the scroller holds after the calendar, so the end stops with the last day under the date. The measurement runs in a layout effect (not on scroll) and with a ResizeObserver on the calendar's parent and the scroller's content box, so a note that rewraps or a sentinel that mounts updates it. true and false are unchanged. Desktop can switch both sites to endSpace="measure".
  2. UiScalePanel's inset card matches desktop. It now uses ring-1 ring-border shadow-sm instead of border border-border, which makes it 2px shorter. The divider is border-foreground/8 and the preset fills are bg-foreground/8 / hover:bg-foreground/6. This is a default change, not a variant: docs (sidebar-controls.tsx) renders UiScaleControl without restyling it, and the web app only names it in a plan doc, so nothing depends on the old look.
  3. PopoverContent surface="glass" (opt-in): desktop's team-chat menu look, rounded-xl bg-card/95 shadow-lg inset-highlight backdrop-blur-glass. This is the recipe the pinned, new-DM, new-channel, rename-channel and call menus used before ATL-888 moved them onto the package. The blur is the package's one glass blur (24px), not desktop's backdrop-blur-2xl (40px). The blur radius never animates, and the docblock says to keep it to small menus.
  4. IconButton icon also takes an element, drawn as given. Callers can pass a spinning refresh or a package glyph (RailGlyph). A Lucide component still draws through Icon at the square's step, so existing callers are unchanged.

Not changed:

  • bg-terminal-background already exists. Code surface: editor and terminal chrome (ATL-874) #20 added --color-terminal-background with the other terminal bridges, and TerminalPalette uses it.
  • Button size="icon-xs" was not re-added. The README's rename table deliberately maps Button size="icon" / icon-xs / icon-sm / icon-lg to IconButton size. ATL-939's needs are covered without it: DOCK_TRIGGER = iconButtonVariants({ variant: "ghost", size: "xs" }) (on ./variants, 20px), and DockButton = <IconButton size="xs" icon={<RailGlyph … />} /> using item 4.

Upgrade notes (for the next release)

  • TimelineCalendar takes endSpace="measure" for a scroller with content after the list.
  • UiScalePanel / UiScaleControl: the inset card is a ring plus shadow-sm (2px shorter), with foreground-tint divider and fills.
  • PopoverContent takes surface="glass".
  • IconButton's icon accepts an element as well as a Lucide component.

Evidence

  • New or updated stories, all passing in test:storybook:
    • Blocks/TimelineCalendar MeasuredEnd: the play scrolls to the end and asserts the last day names the sticky date and its heading lines up within 2px. With endSpace: true the same story fails, which is the bug.
    • Shell/UiScale Panel: the play asserts no border and a shadow beyond the ring.
    • Primitives/Popover Glass: the play asserts a backdrop blur and a radius above rounded-lg.
    • Primitives/IconButton ElementIcon.
  • Gates: typecheck, format:check, theme:check, test (448 passed), test:storybook (692 passed, axe included), test:consumer (ok), build-storybook, storybook:smoke (692 stories).
  • Screenshots in light and dark: atlas-work/shots/ds-gaps-018/.

Merge Danger

  • Low. Items 1, 3 and 4 are opt-in or additive.
  • Item 2 changes how every UiScalePanel looks. That is intended (desktop is the source of truth) and applies to docs' rail control on its next pin bump.
  • No version bump and no tag.

A column that puts padding or a note after the calendar in the same
scroller made the last day overshoot the sticky date. "measure" subtracts
whatever follows the calendar from the end space. true and false are
unchanged.
Ring and a small shadow instead of a border (2px shorter), a
foreground/8 divider, and foreground/8 / foreground/6 fills for the
selected and hovered presets, as desktop's control drew them. Docs and
web render the control without restyling it, so they take the desktop
look.
Desktop team-chat menus were bg-card/95 under a backdrop blur, rounded-xl,
a raised top edge and the dialog-rung shadow. no-restyle keeps call sites
to layout and spacing, so it is a surface variant. Uses the one glass blur
(backdrop-blur-glass, 24px) rather than desktop's 40px.
A Lucide component still draws through Icon at the square's step. An
element draws as given, for a spinning refresh or the package's own
glyphs (RailGlyph). Existing callers are unchanged.
# Conflicts:
#	stories/components/shell/ui-scale.stories.tsx
@uzayer
uzayer merged commit c21bac5 into main Nov 4, 2026
1 check passed
@uzayer uzayer mentioned this pull request Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant