Use uv for dependency management and simplify build script #460
+304
−6,499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmurdza
changed the title
|
|
||
| # Create virtual environment using UV | ||
| print_step "Creating virtual environment with UV..." | ||
| find . -type d -name ".venv" -exec rm -rf {} + 2>/dev/null || true |
There was a problem hiding this comment.
this might be redundant step if uv venv .venv --python 3.12 is idempotent, might also make sense to just rm -rf .venv before too if it it might exist to make the test more reproducible and not get bugs due to existing state vs desired state
| # Create a .env file for VS Code to use the virtual environment | ||
| print_step "Creating .env file for VS Code..." | ||
| echo "PYTHONPATH=${PROJECT_ROOT}/libs/python/core:${PROJECT_ROOT}/libs/python/computer:${PROJECT_ROOT}/libs/python/agent:${PROJECT_ROOT}/libs/python/som:${PROJECT_ROOT}/libs/python/pylume:${PROJECT_ROOT}/libs/python/computer-server:${PROJECT_ROOT}/libs/python/mcp-server" > .env | ||
| echo "PYTHONPATH=${VIRTUAL_ENV}/lib/python${PYTHON_VERSION}/site-packages" > .env |
There was a problem hiding this comment.
this overwrites .env, which could be nasty if i have something there i want to keep
There was a problem hiding this comment.
Yeah! We already have this line: https://github.com/trycua/cua/blob/main/.vscode/py.code-workspace#L58C1-L59C1
So I'm thinking that should be enough for VS Code to locate packages?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the old PDM-based setup with UV for dependency management and refactors the
build-uv.shscript for simplicity and maintainability.Changes
.env.localand manually deleted build caches and artifacts.core,pylume,computer,agent, etc.) separately, install everything from the project root with a singleuv pip install -e .command..venv— any existing virtual environment is removed and rebuilt to ensure a clean setup.PYTHONPATHgeneration — reference the virtual environment’ssite-packagespath instead of hardcoding multiple library pathspdm.lockwithuv.lock