String/replaceall #428
Merged
String/replaceall #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
requested changes
Oct 7, 2024
Member
aapoalas
left a comment
aapoalas
left a comment
There was a problem hiding this comment.
Some optimisations that can be made but looks absolutely good to me aside from a correctness standpoint. Let's make those changes and get this merged!
Thank you and great work! <3
nova_vm/src/ecmascript/builtins/text_processing/string_objects/string_prototype.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/text_processing/string_objects/string_prototype.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/text_processing/string_objects/string_prototype.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/text_processing/string_objects/string_prototype.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/text_processing/string_objects/string_prototype.rs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the comments (every PR to nova is a masterclass of Rust for me). I hope it's okay now! |
aapoalas
reviewed
Oct 8, 2024
nova_vm/src/ecmascript/builtins/text_processing/string_objects/string_prototype.rs
Show resolved
Hide resolved
aapoalas
reviewed
Oct 8, 2024
nova_vm/src/ecmascript/builtins/text_processing/string_objects/string_prototype.rs
Outdated
Show resolved
Hide resolved
aapoalas
reviewed
Oct 8, 2024
nova_vm/src/ecmascript/builtins/text_processing/string_objects/string_prototype.rs
Show resolved
Hide resolved
aapoalas
reviewed
Oct 8, 2024
nova_vm/src/ecmascript/builtins/text_processing/string_objects/string_prototype.rs
Outdated
Show resolved
Hide resolved
aapoalas
previously approved these changes
Oct 8, 2024
Member
aapoalas
left a comment
aapoalas
left a comment
There was a problem hiding this comment.
LGTM! I'll merge this a bit later in case you want to make any changes based on my nitpicks.
Contributor
Author
|
@aapoalas thanks! Don't merge it yet. I'll make the changes, just need a bit more time (I'm busy right now) |
Member
Ah, alright! Don't worry about it <3 |
aapoalas
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again 👋
In this PR I've implemented the
String.prototype.replaceAllfunction.During the implementation I've discovered some bugs in
String.prototype.replacethat are also fixed, specifically:replacefunction works likereplaceAllin javascript (replacing all occurrences). I've changed toreplacen(search, replace, 1)to replace only the first occurence.search.find(subject)instead ofsubject.find(search)).