Implement Promise All Settled #872
Conversation
komyg
force-pushed
the
feature/promise.all_settled
branch
from
6271720 to
16237ab
Compare
komyg
force-pushed
the
feature/promise.all_settled
branch
from
a68dc67 to
fae782c
Compare
aapoalas
left a comment
aapoalas
left a comment
There was a problem hiding this comment.
Wow, this looks great! Only one real blocking nit to pick, and then a couple of suggestions on reducing some repetition in the resolving code.
Absolutely stellar stuff! <3
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Show resolved
Hide resolved
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Outdated
Show resolved
Hide resolved
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Outdated
Show resolved
Hide resolved
...m/src/ecmascript/builtins/control_abstraction_objects/promise_objects/promise_constructor.rs
Outdated
Show resolved
Hide resolved
...tins/control_abstraction_objects/promise_objects/promise_abstract_operations/promise_jobs.rs
Outdated
Show resolved
Hide resolved
komyg
force-pushed
the
feature/promise.all_settled
branch
from
bbf3be7 to
295b9eb
Compare
…ll and PromiseAllSettled
…ection for PromiseAll and PromiseAllSettled, streamlining promise reaction processing.
… fulfillment and rejection handling, improving code clarity and reducing duplication.
komyg
force-pushed
the
feature/promise.all_settled
branch
from
5c6585a to
72715b1
Compare
aapoalas
left a comment
aapoalas
left a comment
There was a problem hiding this comment.
Looks really damn good! But let's "deduplicate" the methods a bit more still; the PromiseAll / PromiseAllSettled handling should be exactly the same in both cases with PromiseAllSettled just wrapping the value in an object before calling the shared handling code.
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Outdated
Show resolved
Hide resolved
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Outdated
Show resolved
Hide resolved
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Outdated
Show resolved
Hide resolved
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Show resolved
Hide resolved
aapoalas
left a comment
aapoalas
left a comment
There was a problem hiding this comment.
LGTM, and great work! I have a feeling the next ones will be ridiculously easy with this work in place :)
|
Oh, @komyg , the test results require updating. |
|
Hey @aapoalas, tests are passing now. I didn't merge the expectations updates before, because that always caused merge conflicts. And yes, I intend to do |
2 participants
No description provided.