chore: remove old todos related to wt8::CodePoint

[GeoffreyParrier]

For both files, functions now returns a wtf8::CodePoint

[GeoffreyParrier]

Small questions, are these comments still relevant?

There is wt8 handling so it seems irrelevant now and could be removed but I didn't want to remove them without being sure

https://github.com/trynova/nova/blob/main/nova_vm/src/ecmascript/types/language/string.rs#L318-L319

[aapoalas]

Small questions, are these comments still relevant?

There is wt8 handling so it seems irrelevant now and could be removed but I didn't want to remove them without being sure

https://github.com/trynova/nova/blob/main/nova_vm/src/ecmascript/types/language/string.rs#L318-L319

I believe there is still some relevance to those comments, although not in the way they say: small strings can be WTF-8 as well nowadays, which means that concatenating two small strings requires special work to check for cases where a pair of unpaired surrogates are concatenated into one another, and a byte marriage is required :)

In effect, that function has a bug that creates... Uuh, library level UB at least.

[aapoalas]

Hello, and welcome to Nova! Thank you for this cleanup, this looks good to me <3

If you want to try fix the WTF-8 concatenation bug in the other function as part of this PR, that's fine by me. Otherwise, I can merge this right away.

[GeoffreyParrier]

Maybe merge this and I'll take a look later, as I'm not familiar with rust or lone surrogate, I prefer not to block this PR