Implement Promise Any #883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komyg
force-pushed
the
feature/promise.any
branch
from
63d3122 to
ee5c496
Compare
komyg
commented
Nov 6, 2025
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Outdated
Show resolved
Hide resolved
komyg
commented
Nov 6, 2025
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Note: I will update the Test 262 statistics after the PR is approved, to avoid merge conflicts. |
aapoalas
requested changes
Nov 10, 2025
Member
aapoalas
left a comment
aapoalas
left a comment
There was a problem hiding this comment.
This looks really good; only the creation of the AggregateError needs to be fixed. I've added an outline of the steps needed to create a correct kind of AggregateError. Basically the important thing is that Errors have to be Value::Error instead of Value::Object to be spec-compliant.
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Show resolved
Hide resolved
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Outdated
Show resolved
Hide resolved
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Outdated
Show resolved
Hide resolved
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Outdated
Show resolved
Hide resolved
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Show resolved
Hide resolved
komyg
force-pushed
the
feature/promise.any
branch
from
8befa40 to
55fc3e8
Compare
komyg
force-pushed
the
feature/promise.any
branch
from
55fc3e8 to
73b16cb
Compare
aapoalas
reviewed
Nov 10, 2025
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Outdated
Show resolved
Hide resolved
aapoalas
reviewed
Nov 10, 2025
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Outdated
Show resolved
Hide resolved
Contributor
Author
Thank you @aapoalas! I've added your suggestions. |
omfj
pushed a commit
to omfj/nova
that referenced
this pull request
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.