Skip to content

Conversation

@aapoalas
Copy link
Member

Two findings:

  1. Stack overflow is very easy to trigger. There's quite little I can do about this per se, as Rust does not give the means to avoid it directly. An experimental limit to the JS call stack depth did, however, fix the crashing.
  2. Allocating very large objects or arrays could panic due to Nova not using try_reserve for elements and keys storage allocations. I changed the code to always use try_reserve and bubble up any errors.

@aapoalas aapoalas linked an issue Nov 21, 2025 that may be closed by this pull request
@aapoalas aapoalas merged commit 81492d6 into main Nov 21, 2025
8 checks passed
@aapoalas aapoalas deleted the fix/process-issues-from-external-security-review branch November 21, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Process issues from external security review

2 participants