fix(ecmascript): fix crash buildins bigint as unit n #898
+31
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
approved these changes
Nov 22, 2025
Member
There was a problem hiding this comment.
Once again, hello and welcome to the project! This looks excellent to me, and great work on getting this working <3
I pushed in a "fix" for the expectations; it's indeed because my Atomics.wait/waitAsync/notify implementation is interfacing directly with the OS futexes and they work a little differently depending on the platform. I'll open an issue about that.
Again: much appreciated, great work, thank you, and welcome! <3
EDIT: The Atomics issue: #899
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #705
I add handling for cases exceeding i64 range.
And fix crash case.
This commit is difference
571c04e