Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for the current state of ts-defold #29

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

thinknathan
Copy link
Member

@thinknathan thinknathan commented Feb 24, 2024

Fixes #28
Fixes #27

I also tried fixing typos and making the capitalization consistent for brand/product names like Github, Lua, etc.

@thinknathan
Copy link
Member Author

I've never used gatsby before. @thejustinwalsh please let me know if any of my edits might break the site.

@thejustinwalsh
Copy link
Member

Edits look good; the more significant issue that we may face upon publication is that Gatsby moves fast and breaks often.
When I was iterating on the site, Gatsby would often break every few months.

The playground site was the hardest thing to set up in Gatsby, and IIRC, it requires some custom webpack config to work.
Otherwise, the entire thing could be migrated to something like VitePress or Docosaurus.

It's probably a good idea to enable CI/CD on PRs to see if it just breaks on Gatsby deps install....

@thinknathan thinknathan reopened this Feb 28, 2024
@thinknathan
Copy link
Member Author

A skip-publish: true version of the CI completed with no errors. So far so good.

@thinknathan thinknathan merged commit 5071ac3 into ts-defold:main Feb 29, 2024
1 check passed
@thinknathan
Copy link
Member Author

Deployment failed because could not read Password for 'https://***@github.com': No such device or address

Maybe it's just a permissions issue? Could you try running the action when you have a moment? @thejustinwalsh

@thejustinwalsh
Copy link
Member

Trying this, enriikke/gatsby-gh-pages-action#12

@thejustinwalsh
Copy link
Member

🚀 https://github.com/ts-defold/ts-defold.github.io/actions/runs/8096138705

@thinknathan
Copy link
Member Author

Thanks for getting that fixed. It's exciting to see the site up-to-date!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Outdated Info Native Extensions
2 participants