Skip to content

Conversation

@Newbie012
Copy link
Collaborator

@Newbie012 Newbie012 commented Dec 22, 2025

Summary by CodeRabbit

  • Chores
    • Enhanced TypeScript type declaration support for the configuration API to improve IDE integration and type checking capabilities.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2025

⚠️ No Changeset found

Latest commit: 31543bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
safeql Ignored Ignored Dec 22, 2025 8:24am

@coderabbitai
Copy link

coderabbitai bot commented Dec 22, 2025

Walkthrough

A typesVersions field was added to packages/eslint-plugin/package.json to map the "config" type declaration to a generated dist/config.d.ts file, enabling proper TypeScript type resolution for the config export.

Changes

Cohort / File(s) Summary
TypeScript type resolution configuration
packages/eslint-plugin/package.json
Added typesVersions field with wildcard version entry mapping "config" public type declaration to ./dist/config.d.ts

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A config type finds its home,
Through typesVersions it can roam,
TypeScript paths aligned just right,
Declaration shining bright! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a typesVersions configuration to the eslint-plugin package.json file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore-eslint-types

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ac7a1b7 and 31543bf.

📒 Files selected for processing (1)
  • packages/eslint-plugin/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: check (16)
  • GitHub Check: check (17)
🔇 Additional comments (1)
packages/eslint-plugin/package.json (1)

14-20: TypeScript version compatibility enhancement looks good.

The typesVersions mapping provides backward compatibility for TypeScript versions < 4.7, which don't fully support the exports field. The path correctly points to ./dist/config.d.ts, matching the default type declaration in your existing exports configuration.

Please verify that dist/config.d.ts is actually generated during the build process:

#!/bin/bash
# Description: Verify that dist/config.d.ts exists after build and check the build configuration

# Check if unbuild configuration generates config.d.ts
fd -t f 'build.config|unbuild.config' --exec cat {}

# Check if there's a source file that would generate config types
fd -t f -e ts -e mts 'config' packages/eslint-plugin/src

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Newbie012 Newbie012 closed this Dec 22, 2025
@Newbie012 Newbie012 deleted the chore-eslint-types branch December 22, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants