Use screen_block_draw to clear prefs area #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to do all of that scaling ourselves when we can just use the screen routines to do it for us. Since screen_block_draw asserts flow control, it was necessary to add a dummy flow-control function, that the flow on/off function pointers can point at until the drivers are loaded.
greg-king5
reviewed
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @greg-king5's comment on PR #40, I reworked
prefs_clearto just usescreen_block_draw, which does all the scaling for us, and got rid of all the redundant scaling logic that I added (and the special-case ifdef for the Apple 2).As a side effect, since
screen_block_drawasserts flow control, it was necessary to add a dummy flow-control function, that the flow on/off function pointers can point at until the drivers are loaded.