feat: add via-to-pad clearance DRC check#154
Open
Timmmmmo wants to merge 1 commit into
Open
Conversation
Implements check-via-pad-clearance that detects when a via is placed too close to a pad (SMT pad or plated hole) on a different net. Key design decisions: - Uses getBoundsOfPcbElements for comprehensive pad shape support (circle, rect, pill, rotated_pill, polygon, etc.) - Via treated as circle, pad as circle or bounding-box polygon - Uses SpatialObjectIndex for efficient neighbor lookup - Shares connectivity map with other DRC checks - Declares local PcbViaPadClearanceError interface (circuit-json doesn't have this type yet) Fixes tscircuit#44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
check-via-pad-clearancethat detects when a via is placed too close to a pad (SMT pad or plated hole) on a different net. Closes #44.Key design decisions
getBoundsOfPcbElementsso that all pad shapes (circle, rect, pill, rotated_pill, polygon, etc.) are handled correctly - not just circle and rectdistanceBetweenCircleAndCircle/distanceBetweenCircleAndPolygonfromcircuit-json-utilgetCircleShapeandgetPolygonShapefrom common.ts: Reuses existing helpers instead of duplicating codePcbViaPadClearanceErrorinterface:circuit-jsondoesn't have this type yet; promoting it upstream would be a natural follow-uprunAllRoutingChecksandindex.tsTest coverage (7 tests)
All 118 tests pass (7 new + 111 existing).