feat: generate In1_Cu and In2_Cu gerber files for 4-layer boards#84
Closed
fancierbread7-ctrl wants to merge 1 commit into
Closed
feat: generate In1_Cu and In2_Cu gerber files for 4-layer boards#84fancierbread7-ctrl wants to merge 1 commit into
fancierbread7-ctrl wants to merge 1 commit into
Conversation
4-layer boards with traces on inner1/inner2 layers were silently dropped from gerber output — only F_Cu and B_Cu were emitted. Changes: - GerberLayerName: add string index signature to allow In1_Cu...In4_Cu - getGerberLayerName: map inner1-inner4 layer refs to In1_-In4_ prefixes - getCommandHeaders: add inner1-inner4 FileFunction entries (Copper,L2,Inr etc.) - getAllTraceWidths: collect trace widths for inner layers too - defineAperturesForLayer: resolve correct layer ref for inner glayer names - index.ts: detect used inner layers, initialize and render them Fixes tscircuit#78 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fancierbread7-ctrl
requested review from
ShiboSoftwareDev and
seveibar
as code owners
Contributor
|
Cc @imrishabh18 |
Contributor
|
This is a pretty serious bug if we dont support 4 layer- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78\n\nFixes 4-layer boards silently exporting as 2-layer. Now generates In1_Cu and In2_Cu gerber files for inner copper layers.