Skip to content

fix the parsing issue of glb files in model viewer #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imrishabh18 merged 1 commit into from
Sep 12, 2025
Merged

fix the parsing issue of glb files in model viewer #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions lib/gltf/gltf-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,17 @@ export class GLTFBuilder {
// JSON chunk
// Binary chunk

const jsonString = JSON.stringify(gltf)
// For GLB format, we need to add a buffer reference to the embedded binary data
const gltfWithBuffer = {
...gltf,
buffers: [
{
byteLength: bufferData.byteLength,
},
],
}

const jsonString = JSON.stringify(gltfWithBuffer)
const jsonData = new TextEncoder().encode(jsonString)

// Pad JSON to 4-byte alignment
Expand All @@ -723,9 +733,13 @@ export class GLTFBuilder {
view.setUint32(12, jsonLength, true) // chunk length
view.setUint32(16, 0x4e4f534a, true) // chunk type "JSON"

// Copy JSON data
const jsonArray = new Uint8Array(glb, 20, jsonData.length)
// Copy JSON data and pad with spaces
const jsonArray = new Uint8Array(glb, 20, jsonLength)
jsonArray.set(jsonData)
// Fill padding bytes with spaces (0x20) as required by GLB spec
for (let i = jsonData.length; i < jsonLength; i++) {
jsonArray[i] = 0x20
}

// Binary chunk
const binChunkOffset = 20 + jsonLength
Expand Down
Loading