feat: add GLTF model loading support for cadModel.gltfUrl#11
Closed
lessuselesss wants to merge 10 commits into
Closed
feat: add GLTF model loading support for cadModel.gltfUrl#11lessuselesss wants to merge 10 commits into
lessuselesss wants to merge 10 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Implement complete GLTF 2.0 parser with security validation - Add pipeline integration following STL/OBJ patterns - Include 91 comprehensive tests with performance benchmarks - Support cadModel.gltfUrl in circuit-json processing
lessuselesss
force-pushed
the
feat/gltf-support
branch
from
b506a9d to
1ca10da
Compare
- Apply Biome formatting to all GLTF implementation files - Fix formatting issues in tests and core implementation - Ensure consistency with project style guidelines
added 3 commits
September 17, 2025 09:31
- Add non-null assertions for coordinate transformations in geometry.ts - Fix async function syntax for mock fetch functions - Add assertions for array access patterns Progress on fixing CI type check failures
- Add non-null assertions for test array access - Fix fetch mock function syntax for type compatibility - Resolve undefined access errors in performance tests Reduced TypeScript errors from ~80 to ~59
- Fix undefined handling with nullish coalescing in geometry transforms - Add proper type assertions for array element access - Fix fetch mock typing with unknown cast for test compatibility - Add ts-ignore for model-viewer web component JSX element - All TypeScript checks now passing (0 errors) Tests: 91 passing, 0 failing TypeScript: No errors
lessuselesss
force-pushed
the
feat/gltf-support
branch
from
19489e4 to
61ccdc9
Compare
- Fix formatting for integration and loader test files - Ensure code style consistency with project standards - Final formatting fix for CI compliance
- Remove flake.nix, flake.lock, .envrc (Nix development setup) - Remove TESTING_TODO.md (internal testing notes) - Clean up repository for production submission
- Remove implementation guide used during development - Clean submission without internal development docs
added 2 commits
September 17, 2025 11:09
- Remove rebuild-sharp.sh (development script) - Remove development file patterns from .gitignore - Clean PR to only include production GLTF implementation
- Remove accidentally created CLADE.md file - Complete cleanup of development artifacts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/lib/loaders/gltf.tswith full GLTF 2.0 JSON parsingImplementation Details
model_gltf_urlsupport in circuit-json processingTesting
bun test- All 91 tests passCloses
Completes the final task in tscircuit/tscircuit#758: "add in circuit-json-to-gltf"