Add Copper Pour Export#264
Open
mohan-bee wants to merge 12 commits intotscircuit:mainfrom
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar
requested changes
May 7, 2026
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
no snapshot test how do we know this works?
Contributor
|
you need a stacked tscircuit/kicad png |
techmannih
reviewed
May 7, 2026
Member
techmannih
left a comment
techmannih
left a comment
There was a problem hiding this comment.
also you need to add the kicad file which snapshots which you are converting from cj-> kicad
Member
|
Yep you need to convert that into kicad also I'm curious about to see the kicad file |
seveibar
reviewed
May 7, 2026
| const kicadLayer = getKicadLayer(pour.layer) | ||
|
|
||
| const zone = new Zone() | ||
| zone.rawChildren = [ |
Contributor
There was a problem hiding this comment.
this should not exist, remove rawChildren from zones in kicadts and make sure it supports all these properties natively
seveibar
requested changes
May 7, 2026
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
see comment, also not that you clearly did not import the copper pour correctly based on the snapshot
This reverts commit a7fcde2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: Copper pours are a core PCB feature, so the exporter should preserve them in the output.
What Changed: Copper pours are now emitted with correct geometry (rect, polygon, BRep), mapped to the right net, and use clear default fill settings.