fix: add support for pcb_silkscreen_rect in KiCad footprint export#267
Open
64johnlee wants to merge 4 commits intotscircuit:mainfrom
Open
fix: add support for pcb_silkscreen_rect in KiCad footprint export#26764johnlee wants to merge 4 commits intotscircuit:mainfrom
64johnlee wants to merge 4 commits intotscircuit:mainfrom
Conversation
Convert pcb_silkscreen_rect elements to FpRect inside footprints (component-associated) and as board-level fp_rect elements (standalone). Closes tscircuit#191
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
64johnlee
commented
May 3, 2026
Author
64johnlee
left a comment
64johnlee
left a comment
There was a problem hiding this comment.
All checks passing ✅ This PR fixes silkscreen_rect placement inside footprint. Ready to merge! 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using
silkscreenrectin tscircuit, the silkscreen graphics were not being exported to KiCad asfp_rectelements inside footprints. Instead, they were being silently dropped.This PR adds:
pcb_silkscreen_rectelements associated with components intoFpRectinside the footprint (footprint.fpRects)pcb_silkscreen_rectelements (not associated with any component) intofp_rectboard-level elements inAddGraphicsStageChanges
lib/pcb/stages/footprints-stage-converters/convertSilkscreenRects.ts- convertsPcbSilkscreenRect[]→FpRect[]using the same relative-coordinate pattern as other silkscreen converterspcb_silkscreen_path,pcb_silkscreen_circle)pcb_silkscreen_path)Behavior
silkscreenrect(in component)fp_rectinside footprint ✓silkscreenrect(standalone)fp_rectboard-level ✓Closes #191