fix: support component names like U_TEST in reference designator (issue #227)#268
Open
64johnlee wants to merge 4 commits intotscircuit:mainfrom
Open
fix: support component names like U_TEST in reference designator (issue #227)#26864johnlee wants to merge 4 commits intotscircuit:mainfrom
64johnlee wants to merge 4 commits intotscircuit:mainfrom
Conversation
…ern (issue tscircuit#227) The pattern /^[A-Za-z]+\d+$/ was too strict - it only matched names like R1, U1, C1 but not U_TEST, VCC_MAIN, etc. Now supports: U_TEST, R_1, VCC, U1, R1, etc. Add test case for issue tscircuit#227
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #227: Reference designators empty on custom inline footprints
Root cause: The
referenceDesignatorPatternwas/^[A-Za-z]+\d+$/which only matched names likeR1,U1,C1but notU_TEST,VCC,R_1, etc.Fix: Extended pattern to
/^[A-Za-z]+[A-Za-z0-9_-]*[A-Za-z0-9]$|^[A-Za-z]+\d+$/Closes #227