feat: generate courtyardrect from pcb_courtyard_rect#20
Open
makaiachildress-web wants to merge 5 commits intotscircuit:mainfrom
Open
feat: generate courtyardrect from pcb_courtyard_rect#20makaiachildress-web wants to merge 5 commits intotscircuit:mainfrom
makaiachildress-web wants to merge 5 commits intotscircuit:mainfrom
Conversation
Generate <courtyardrect /> TSX elements from pcb_courtyard_rect circuit-json elements, supporting the courtyard feature for KiCad component footprints. Related: tscircuit/tscircuit#1081 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds test7-courtyard-rect.test.tsx with two test cases: - Courtyard rect with layer attribute - Courtyard rect without layer (omits layer prop) Both verify correct pcbX, pcbY, width, height, and layer mapping from pcb_courtyard_rect circuit JSON to <courtyardrect /> TSX. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Tests using runTscircuitCode were timing out at the default 5s in GitHub Actions. Set per-test timeout to 30s for tests that invoke the tscircuit code evaluator. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for converting pcb_courtyard_rect circuit JSON elements into TSX elements during footprint code generation. This completes the circuit-json-to-tscircuit part of the courtyard pipeline for KiCad-imported components.
/claim #1081
Changes
Feature: courtyard rect generation (lib/generate-footprint-tsx.tsx)
Tests: test7-courtyard-rect.test.tsx (new)
Fix: CI test timeout (test5, test6)
Test plan