Fix source‑subcircuit imports by preserving connectivity and props#26
Open
mohan-bee wants to merge 6 commits intotscircuit:mainfrom
Open
Fix source‑subcircuit imports by preserving connectivity and props#26mohan-bee wants to merge 6 commits intotscircuit:mainfrom
mohan-bee wants to merge 6 commits intotscircuit:mainfrom
Conversation
Author
|
linked circuit-json-to-tscircuit locally Screen.Recording.2026-04-08.at.3.19.44.PM.mov |
seveibar
requested changes
Apr 8, 2026
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
The function you modified is for creating a component, if we merged this we would break stuff everywhere.
Importing a board as circuit json uses a different flow generally, corcuit json can be dorectly provided to a board
Author
|
Can you give me some idea of how the flow needs to be ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
users importing source‑based exports were hitting incorrect or ambiguous connectivity, making the resulting component unusable on boards.
Proof:
Screen.Recording.2026-04-08.at.12.16.34.PM.mov
Reproduction in circuit-json-to-tscircuit:
Screen.Recording.2026-04-08.at.11.26.03.AM.mov
The fix changes the import path so full source-based Circuit JSON is rebuilt as a board-style source design instead of a flat footprint blob