feat: add pcb_courtyard_polygon and pcb_courtyard_circle to footprint TSX generation#27
Open
Kabi10 wants to merge 2 commits intotscircuit:mainfrom
Open
feat: add pcb_courtyard_polygon and pcb_courtyard_circle to footprint TSX generation#27Kabi10 wants to merge 2 commits intotscircuit:mainfrom
Kabi10 wants to merge 2 commits intotscircuit:mainfrom
Conversation
… TSX generation Resolves tscircuit/tscircuit#1081 — make sure kicad component components create courtyards. Adds <courtyardpolygon> and <courtyardcircle> JSX element generation to generate-footprint-tsx.tsx, covering all 4 courtyard circuit-json types: - pcb_courtyard_outline → <courtyardoutline> (existing) - pcb_courtyard_rect → <courtyardrect> (existing) - pcb_courtyard_polygon → <courtyardpolygon> (new) - pcb_courtyard_circle → <courtyardcircle> (new) Tests added to verify both new element types are emitted correctly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4 tasks
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
Context for reviewers: PR #25 (merged 2026-03-06) added The kicad-component-converter already parses all 4 courtyard types from KiCad files (see
This PR closes those two gaps, completing full round-trip coverage for all 4 courtyard types: KiCad file -> circuit-json -> TSX footprint. |
Author
|
Closing since tscircuit/tscircuit#1081 was closed as completed without a reward being issued. The implementation is correct and complete — happy to reopen if the bounty is revisited. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves tscircuit/tscircuit#1081 — "Make sure kicad component components create courtyards"
<courtyardpolygon>JSX output forpcb_courtyard_polygoncircuit-json elements<courtyardcircle>JSX output forpcb_courtyard_circlecircuit-json elementsstrokeWidth,isFilled,hasStroke,isStrokeDashed,colorfor polygons;strokeWidth,colorfor circlesBefore
All 4 courtyard types are already produced by
kicad-component-converterand rendered bycircuit-to-svg, but onlypcb_courtyard_outlineandpcb_courtyard_rectwere being converted to TSX footprint elements. Polygon and circle courtyard shapes were silently dropped.After
Full round-trip coverage for all 4 courtyard types:
pcb_courtyard_outline<courtyardoutline>(existing)pcb_courtyard_rect<courtyardrect>(existing)pcb_courtyard_polygon<courtyardpolygon>✨ newpcb_courtyard_circle<courtyardcircle>✨ newTest plan
test("test8 support courtyard polygon and circle")verifying both new elements are emitted with correct attributes/claim #1081
🤖 Generated with Claude Code