Add courtyard circle support#32
Merged
techmannih merged 1 commit intotscircuit:mainfrom May 6, 2026
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for converting
pcb_courtyard_circlecircuit-json elements into<courtyardcircle />in generated tscircuit footprints.What Changed
pcb_courtyard_circlehandling ingenerateFootprintTsx<courtyardcircle pcbX={...} pcbY={...} radius={...} layer="..." />circuit-jsonfrom^0.0.391to^0.0.423so the newer courtyard circle type/accessor is availableWhy
Courtyard outlines and rects were already supported, but courtyard circles were being skipped. This made the converter incomplete for footprints that use circular courtyard geometry.
Impact
Footprints containing
pcb_courtyard_circlenow round-trip correctly from circuit-json to generated tscircuit code and back.Validation
bunx tsc --noEmitbun test