Skip to content

Export kicadFootprintStrings#2047

Merged
MustafaMulla29 merged 1 commit intomainfrom
fix/kic-strings
Mar 13, 2026
Merged

Export kicadFootprintStrings#2047
MustafaMulla29 merged 1 commit intomainfrom
fix/kic-strings

Conversation

@MustafaMulla29
Copy link
Contributor

@MustafaMulla29 MustafaMulla29 commented Mar 13, 2026

eval is not able to find kicadFootprintStrings as it does:

preSuppliedImports: {
      "@tscircuit/core": tscircuitCore,
      tscircuit: tscircuitCore,
      "@tscircuit/math-utils": tscircuitMathUtils,
      react: React,
      "react/jsx-runtime": ReactJsxRuntime,
      debug: Debug,
      tslib,

      // This is usually used as a type import, we can remove the shim when we
      // ignore type imports in getImportsFromCode
      "@tscircuit/props": {},
    },

Where it uses core for tscircuit, otherwise will have to spread it in core if its not exported from core. Even though kicadFootprintStrings is exported from tscircuit dep

@vercel
Copy link

vercel bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview, Comment Mar 13, 2026 10:45am

Request Review

@MustafaMulla29 MustafaMulla29 merged commit 2436111 into main Mar 13, 2026
12 checks passed
@MustafaMulla29 MustafaMulla29 deleted the fix/kic-strings branch March 13, 2026 15:12
@tscircuitbot
Copy link
Contributor


Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants