feat: schematic_disabled metadata flag and port schematic fix#2072
Closed
mohan-bee wants to merge 4 commits intotscircuit:mainfrom
Closed
feat: schematic_disabled metadata flag and port schematic fix#2072mohan-bee wants to merge 4 commits intotscircuit:mainfrom
mohan-bee wants to merge 4 commits intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
imrishabh18
requested changes
Mar 24, 2026
Comment on lines
+215
to
+222
| } as any) | ||
| } else { | ||
| this.db.source_project_metadata.update( | ||
| (existing as any).source_project_metadata_id, | ||
| { | ||
| schematic_disabled: this.schematicDisabled, | ||
| } as any, | ||
| ) |
Member
There was a problem hiding this comment.
This is incorrect, you need to add support for the schematic_disabled in circuit-json first
Author
There was a problem hiding this comment.
ok letme add the schematic_disabled support in the circuit-json also !
Author
There was a problem hiding this comment.
in order to test this file I don't find any tests there can I create one ! or stick to default ?
Contributor
There was a problem hiding this comment.
Yes you can create test if there isn't one
Author
|
I have added the support here ! |
Author
|
@imrishabh18 after the PR merge I will remove the 'as any' casts |
Contributor
|
What's the point of this pr? How does it help users? the entire premise for this to be used for panel detection is a hack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1837
Added schematic_disabled flag to source_project_metadata also and detects panels automatically.
Also added memoization to board lookups, resolving bottlenecks in multi-board panels.
Updated the snapshots to fully reflect the empty schematic state.