Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
imrishabh18
approved these changes
Mar 24, 2026
imrishabh18
reviewed
Mar 24, 2026
| }) | ||
| expect(circuit).toMatchSchematicSnapshot(import.meta.path) | ||
| }, | ||
| { timeout: 80000 }, |
Member
There was a problem hiding this comment.
why did you add this timeout?
imrishabh18
reviewed
Mar 24, 2026
| }) | ||
| expect(circuitJson).toMatchPcbSnapshot(import.meta.path) | ||
| }, | ||
| { timeout: 60000 }, |
Member
There was a problem hiding this comment.
These timeouts will slow down the tests in CI. remove those
Contributor
Author
There was a problem hiding this comment.
without these timeouts, its failing in the CI here, they are timing out here @imrishabh18
Member
There was a problem hiding this comment.
Okay, I saw seve merged some new changes. It's happening because of that.
Contributor
Author
|
@imrishabh18 as you can see here, its timing out |
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.