[BOUNTY #86] Fix same-net traces not visually merged in schematic#2074
Open
zhaog100 wants to merge 1 commit intotscircuit:mainfrom
Open
[BOUNTY #86] Fix same-net traces not visually merged in schematic#2074zhaog100 wants to merge 1 commit intotscircuit:mainfrom
zhaog100 wants to merge 1 commit intotscircuit:mainfrom
Conversation
…race merging When two same-net components are placed further apart (schX distance > 2.4), the schematic trace solver fails to create a continuous connection because the default maxMspPairDistance is too restrictive. This fix increases the default from 2.4 to 5, which allows same-net traces to properly merge when components are spaced further apart (e.g. JP6 to R1 with schX=-4 and schX=-0.2). Closes tscircuit#86
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #86 — When two same-net components are placed further apart (schX distance > 2.4), the schematic trace solver fails to create a continuous connection.
Problem
The default
maxMspPairDistancewas set to 2.4, which is too restrictive. When components like JP6 (schX=-4) and R1 (schX=-0.2) are spaced further apart, the solver would skip creating traces between them, resulting in visually broken connections.Solution
Increase the default
maxMspPairDistancefrom 2.4 to 5 increateSchematicTraceSolverInputProblem.ts.Changes
lib/components/primitive-components/Group/Group_doInitialSchematicTraceRender/createSchematicTraceSolverInputProblem.ts: Changed defaultmaxMspPairDistancefrom 2.4 to 5repro49-same-net-not-combinetestTesting
repro49-same-net-not-combinetest passesCloses #86